refactor: unify android runtime c++ layout#45
Open
DjDeveloperr wants to merge 16 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platforms/android, while sharing Android C++ throughNativeScript/runtime/android,NativeScript/napi/android, andNativeScript/ffi/jni/napiNativeScript/ffi/objcand update generated-output/test wiring for the unified layoutHERMESandSHERMESonto the same Static Hermes (shermes) header/library surface already used by Apple;SHERMESremains only a compatibility engine selectorCommit Review Order
b16346f1refactor: move objc ffi under platform namespace055964e5refactor: move android jni napi ffi into shared treea0a2ed87refactor: move android runtime sources into shared tree8d214e29refactor: move android napi engines into shared tree04c486berefactor: wire android build to unified runtime layout3aab3c3bfix(apple): update objc ffi generated paths4def1b90fix(android): align hermes napi adapters86dec82ffix(android): preserve unified runtime behaviorda00c3affix(android): stabilize runtime test harnessfd62fdb5test(android): gate engine-specific runtime specs6bff08eefix: clean up runtime refactor paths15d7c2a4refactor(android): unify static hermes backend98918758fix(jni): handle static hermes constructor receivers5bc35047fix(objc): preserve bridge object ownership1668c885fix(quickjs): clear weak refs before forced gc6ba820c1test(ios): skip app main in scripted runnerValidation
/tmp/ns-runtime-android-matrix-final3:V8-10,V8-11,V8-13,QUICKJS,QUICKJS_NG,HERMES,SHERMES,JSC,PRIMJS: all PASS/tmp/ns-runtime-apple-matrix-final7:v8: 713 specs, 0 failures, 13 skippedhermes: 713 specs, 0 failures, 11 skippedquickjs: 713 specs, 0 failures, 13 skippedjsc: 713 specs, 0 failures, 13 skipped/tmp/ns-runtime-apple-matrix-final7:v8: 713 specs, 0 failures, 10 skippedhermes: 713 specs, 0 failures, 8 skippedquickjs: 713 specs, 0 failures, 10 skippedjsc: 713 specs, 0 failures, 10 skippedprimjs,quickjs_ng,v8-10,v8-11, andv8-13are still unsupported/unwired on Apple in this PRgit diff --checknpm run check:ffi-boundariespython3 -m py_compile metadata-generator/build-step-metadata-generator.py